Skip to content

Fix mono native warnings from wasm targets #64650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 9, 2022
Merged

Conversation

am11
Copy link
Member

@am11 am11 commented Feb 1, 2022

This is to fix native warnings in Build Browser wasm Linux release Runtime_Release succeeded logs https://dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_apis/build/builds/1584905/logs/23 and Build Linux arm Debug AllSubsets_Mono https://dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_apis/build/builds/1586244/logs/523

@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-VM-meta-mono labels Feb 1, 2022
@am11 am11 force-pushed the feature/build/mono branch from def4304 to 3880055 Compare February 2, 2022 10:20
@am11 am11 marked this pull request as ready for review February 2, 2022 10:21
@am11
Copy link
Member Author

am11 commented Feb 2, 2022

cc @lambdageek, I experimented with unconditionally enabling Werror by default (in order to preserve the good, warning-free, state) but it started to fail other legs. Needs more work to get there.

@jkotas jkotas closed this Feb 8, 2022
@jkotas jkotas reopened this Feb 8, 2022
@jkotas jkotas merged commit 32111e1 into dotnet:main Feb 9, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-VM-meta-mono community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants