[release/6.0-maui] transform sgen_get_descriptor to parallel safe version in job_major_mod_union_preclean #63296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…od_union_preclean Fixes mono/mono#21369 job_major_mod_union_preclean can race with the tarjan bridge implementation that changes the vtable pointer by settings the three lower bits. this results in invalid loading of the vtable (shifted by 7 bytes) which in turn give a wrong desc to the scan functions This change is released under the MIT license.
github-actions
bot
requested review from
BrzVlad,
lambdageek and
naricc
as code owners
ghost
added
the
|
Tagging subscribers to this area: @BrzVlad Issue DetailsBackport of #63293 to release/6.0-maui Customer ImpactTestingRisk
|
lambdageek
approved these changes
Jan 3, 2022
steveisok
approved these changes
Jan 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #63293 to release/6.0-maui
/cc @lambdageek @monojenkins
Customer Impact
Fixes concurrency crashes in Xamarin Android apps during GC. Related to mono/mono#21369 and dotnet/android#6546
Testing
Risk