Revert SafeBuffer change around pointer initialization #63289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
marek-safar
reviewed
Jan 3, 2022
| @@ -153,6 +153,8 @@ public void AcquirePointer(ref byte* pointer) | |||
| if (_numBytes == Uninitialized) | |||
| throw NotInitialized(); | |||
|
|
|||
| pointer = null; | |||
There was a problem hiding this comment.
Could you add pragma warning around this with reference to the issue?
There was a problem hiding this comment.
I'm not a big fan of adding suppression for things we don't have enabled. We'd have an absolute ton of such suppression across SPC and the rest of the repo if we did that.
marek-safar
approved these changes
Jan 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #63020 (comment)
cc: @marek-safar