Skip to content

A few minor tweaks to Regex source generator rendering #63276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 4, 2022

Conversation

stephentoub
Copy link
Member

  • Rename the FindFirstChar lable from ReturnFalse to NoStartingPositionFound
  • Separate some code in back reference handling with a blank line
  • Make optionals (?) render as "Optional" rather than as "Loop"
  • Avoid "at least 0" in loop descriptions
  • Avoid an unnecessary addition at run-time in EndZ anchor handling

@stephentoub stephentoub added this to the 7.0.0 milestone Jan 3, 2022
@ghost
Copy link

ghost commented Jan 3, 2022

Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Rename the FindFirstChar lable from ReturnFalse to NoStartingPositionFound
  • Separate some code in back reference handling with a blank line
  • Make optionals (?) render as "Optional" rather than as "Loop"
  • Avoid "at least 0" in loop descriptions
  • Avoid an unnecessary addition at run-time in EndZ anchor handling
Author: stephentoub
Assignees: -
Labels:

area-System.Text.RegularExpressions, tenet-performance

Milestone: 7.0.0

@ghost ghost assigned stephentoub Jan 3, 2022
Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephentoub stephentoub merged commit 80f6845 into dotnet:main Jan 4, 2022
@stephentoub stephentoub deleted the tweakrendering branch January 4, 2022 01:38
@ghost ghost locked as resolved and limited conversation to collaborators Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants