Skip to content

.NET number values such as positive and negative infinity cannot be written as valid JSON. #62690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jan 10, 2022

Conversation

deeprobin
Copy link
Contributor

See issue #48926.

/cc @layomia
/cc @GrabYourPitchforks

@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-System.Text.Json labels Dec 12, 2021
@ghost
Copy link

ghost commented Dec 12, 2021

Tagging subscribers to this area: @dotnet/area-system-text-json
See info in area-owners.md if you want to be subscribed.

Issue Details

See issue #48926.

/cc @layomia
/cc @GrabYourPitchforks

Author: deeprobin
Assignees: -
Labels:

area-System.Text.Json, community-contribution

Milestone: -

Copy link
Contributor

@layomia layomia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should also update the exception message as suggested in #48926 (comment).

Co-authored-by: Layomi Akinrinade <layomia@gmail.com>
@deeprobin deeprobin requested a review from layomia December 13, 2021 18:33
Co-authored-by: Layomi Akinrinade <layomia@gmail.com>
deeprobin and others added 2 commits December 14, 2021 18:22
Co-authored-by: Krzysztof Wicher <mordotymoja@gmail.com>
@deeprobin deeprobin requested a review from krwq December 14, 2021 17:25
Copy link
Contributor

@layomia layomia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more comments, then LGTM.

deeprobin and others added 2 commits December 20, 2021 23:11
Co-authored-by: Layomi Akinrinade <layomia@gmail.com>
@deeprobin deeprobin requested a review from layomia December 21, 2021 20:55
@deeprobin
Copy link
Contributor Author

Couple more comments, then LGTM.

dotnet/dotnet-api-docs#7488 was merged, so I think this could be merged as well

Copy link
Contributor

@layomia layomia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @deeprobin!

@layomia layomia merged commit 7242690 into dotnet:main Jan 10, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Feb 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Text.Json community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants