Skip to content

[wasm][debugger] Add Browsable Attribute support. #62045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 52 commits into from
Jan 3, 2022
Merged

[wasm][debugger] Add Browsable Attribute support. #62045

merged 52 commits into from
Jan 3, 2022

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Nov 25, 2021 •
edited by thaystg
Loading

Task: add DebuggerBrowsableAttribute feature to the wasm debugger.

Expected behavior: doc.

  • Changing expected behavior for MulticastDelegateTest - in Console Application EventHandler is Browsable.Never by default so we should not expect it to be visible in the debug window.

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-Debugger-mono labels Nov 25, 2021
@ilonatommy ilonatommy requested a review from thaystg November 25, 2021 10:32
@ilonatommy ilonatommy self-assigned this Nov 25, 2021
@ghost
Copy link

ghost commented Nov 25, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Task: add DebuggerBrowsableArrtibute feature to the wasm debugger.

Expected behavior: doc.

Author: ilonatommy
Assignees: ilonatommy
Labels:

arch-wasm, area-Debugger-mono
Milestone: -

@ilonatommy ilonatommy marked this pull request as ready for review December 1, 2021 16:06
@ilonatommy ilonatommy removed the request for review from marek-safar December 1, 2021 16:07
radical
radical previously requested changes Dec 1, 2021
View reviewed changes
Copy link
Member

@radical radical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review. This is looking good, just have some suggestions.

@ghost ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Dec 1, 2021
@ilonatommy @radical
Update docs/design/mono/debugger.md
973bd3a 
Co-authored-by: Ankit Jain <radical@gmail.com>
@ghost ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Dec 2, 2021
@ilonatommy ilonatommy requested a review from radical December 2, 2021 10:35
@ilonatommy ilonatommy marked this pull request as ready for review December 21, 2021 11:39
@ilonatommy ilonatommy requested review from thaystg and removed request for thaystg December 21, 2021 11:40
@ilonatommy ilonatommy requested a review from thaystg December 21, 2021 13:21
thaystg
thaystg reviewed Dec 22, 2021
View reviewed changes
thaystg
thaystg reviewed Dec 22, 2021
View reviewed changes
thaystg
thaystg reviewed Dec 22, 2021
View reviewed changes
Copy link
Member

@thaystg thaystg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file added?
image

@ilonatommy ilonatommy requested a review from thaystg January 3, 2022 09:42
@ilonatommy ilonatommy mentioned this pull request Jan 3, 2022
Merged
7 tasks
thaystg
thaystg approved these changes Jan 3, 2022
View reviewed changes
Copy link
Member

@thaystg thaystg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilonatommy ilonatommy merged commit 7574e03 into dotnet:main Jan 3, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Feb 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radical radical radical left review comments

@thaystg thaystg thaystg approved these changes

Assignees

@ilonatommy ilonatommy

Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilonatommy @thaystg @radical