Ensure that we don't try to get the simdBaseJitType for scalar intrinsics #61982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsThis resolves
|
echesakov
reviewed
Nov 30, 2021
| unsigned int sizeBytes; | ||
|
|
||
| simdBaseJitType = getBaseJitTypeAndSizeOfSIMDType(clsHnd, &sizeBytes); | ||
| assert((category == HW_Category_Special) || (category == HW_Category_Helper) || (sizeBytes != 0)); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Do we need to add check for !isScalarIsa(isa) below - line 795 in the new version of the file?
There was a problem hiding this comment.
Yes, its probably good to cover that scenario pre-emptively.
Nothing will hit it today, but it fits with the changes already being made.
echesakov
approved these changes
Dec 2, 2021
|
This should also fix #62117 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #61901