Add NetCoreAppCurrent configurations to Microsoft.Extensions libraries #61867
Conversation
This makes all Extensions projects consistent in which TFMs they target. This way we don't need to add new TFMs during development of a new feature. Fix dotnet#54012
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
ghost
added
|
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue DetailsThis makes all Extensions projects consistent in which TFMs they target. This way we don't need to add new TFMs during development of a new feature. Fix #54012 It is probably easiest to review the commits separately.
@buyaa-n - can you review the supported platforms work I did in the 2nd commit? (note that I ran into dotnet/roslyn-analyzers#4282 and worked around it with redundant Debug.Asserts).
|
...crosoft.Extensions.Caching.Abstractions/src/Microsoft.Extensions.Caching.Abstractions.csproj
Show resolved
Hide resolved
...ies/Microsoft.Extensions.Configuration.Xml/ref/Microsoft.Extensions.Configuration.Xml.csproj
Show resolved
Hide resolved
...rosoft.Extensions.Hosting.WindowsServices/src/WindowsServiceLifetimeHostBuilderExtensions.cs
Show resolved
Hide resolved
| } | ||
|
|
||
| if ((_activityTrackingOption & ActivityTrackingOptions.Baggage) != 0) | ||
| { | ||
| // Only access activity.Baggage as every call leads to an allocation | ||
| IEnumerable<KeyValuePair<string, string?>> baggage = activity.Baggage; |
There was a problem hiding this comment.
why we removed the nullability here? Activity.Baggage is already defined as nullable I guess
There was a problem hiding this comment.
Because the rest of the library doesn't have nullability enabled. And since we don't, the compiler is warning. These changes will likely be undone when we enable nullability in this library.
src/libraries/Microsoft.Extensions.Configuration.Xml/src/XmlDocumentDecryptor.cs
Outdated
Show resolved
Hide resolved
LGTM, thanks! |
This makes all Extensions projects consistent in which TFMs they target. This way we don't need to add new TFMs during development of a new feature.
Fix #54012
It is probably easiest to review the commits separately.
@buyaa-n - can you review the supported platforms work I did in the 2nd commit? (note that I ran into dotnet/roslyn-analyzers#4282 and worked around it with redundant Debug.Asserts).