Skip to content

[wasm] Build improvements, and fixes #61581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Dec 4, 2021
Merged

[wasm] Build improvements, and fixes #61581

merged 13 commits into from
Dec 4, 2021

Conversation

radical
Copy link
Member

@radical radical commented Nov 15, 2021 •
edited
Loading

Includes:

Fixes #60862

@ghost ghost added the area-Build-mono label Nov 15, 2021
@radical radical added the arch-wasm WebAssembly architecture label Nov 15, 2021
@ghost
Copy link

ghost commented Nov 15, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: radical
Assignees: -
Labels:

arch-wasm, area-Build-mono
Milestone: -

@runfoapp runfoapp bot mentioned this pull request Nov 15, 2021
Closed
@radical radical force-pushed the wasm-build-fixes branch 3 times, most recently from 872bcc1 to 178f28d Compare November 30, 2021 22:37
@radical
[wasm] Add @(NativeFileReference) to up-to-date check items for VS
28eecd8 
VS does its own tracking of inputs/outputs too, and needs to be told
about `@(NativeFileReference)` items, so a build can get triggered with
F5 when a native file changes.

Based on https://github.com/dotnet/project-system/blob/main/docs/up-to-date-check.md?rgh-link-date=2021-10-26T13%3A23%3A47Z#up-to-date-check

Fixes dotnet#60862
@radical
MonoAOTCompiler: log failed output as error
aa84a54
@radical
[wasm] Improve error message when runtime pack cannot be found
cc2666e
@radical
[wasm] PInvokeTableGenerator: don't fail on errors in reading custom …
cd18aff 
…attributes

Inspired by https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1364890?src=WorkItemMention&src-action=artifact_link

Works around a NRE in CustomAttributeData.AttributeType because it's
ConstructorInfo is null.
The mono side issue: mono/mono#15340
@radical
Copy link
Member Author

radical commented Dec 2, 2021

/azp run runtime-manual

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical radical changed the title [wasm] build improvements, and fixes [wasm] Build improvements, and fixes Dec 2, 2021
@radical radical marked this pull request as ready for review December 2, 2021 20:03
@radical radical requested a review from marek-safar as a code owner December 2, 2021 20:03
lambdageek
lambdageek reviewed Dec 2, 2021
View reviewed changes
@radical radical requested a review from lambdageek December 3, 2021 18:18
@radical
Copy link
Member Author

radical commented Dec 3, 2021

/azp run runtime-manual

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Dec 3, 2021

Merged main to pick up the fix for #62303 .

@radical
Copy link
Member Author

radical commented Dec 3, 2021

/azp run runtime-manual

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical radical mentioned this pull request Dec 3, 2021
Closed
@radical
Copy link
Member Author

radical commented Dec 4, 2021

/azp run runtime-manual

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Dec 4, 2021

Wasm/AOT tests failing due to #62362 , added part of #62352 .

@radical radical mentioned this pull request Dec 4, 2021
Closed
9 tasks
@radical
Copy link
Member Author

radical commented Dec 4, 2021

/azp run runtime-manual

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical radical merged commit f179b76 into dotnet:main Dec 4, 2021
@radical radical deleted the wasm-build-fixes branch December 4, 2021 06:48
@radical
Copy link
Member Author

radical commented Dec 6, 2021

/backport to release/6.0

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2021

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1546353274

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2021

@radical an error occurred while backporting to release/6.0, please check the run log for details!

Error: @radical is not a repo collaborator, backporting is not allowed.

@radical radical mentioned this pull request Dec 14, 2021
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Jan 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lewing lewing lewing approved these changes

@lambdageek lambdageek lambdageek approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

@vargaz vargaz Awaiting requested review from vargaz

Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WebAssembly <NativeFileReference> isn't included in VS's fast up-to-date check
3 participants
@radical @lewing @lambdageek