Fix bug where we reference the entry #0 in the pinned plug queue #60966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dex 0 when there may be no pinned plugs at all, and thus the refenced entry would be invalid.
|
Tagging subscribers to this area: @dotnet/gc Issue DetailsWe reference entry #0 in the pinned plug queue even if there are no pinned plugs at all and thus the pinned plug queue contains left-over data from the mark phase. This is #60617 without the saving of the pinned plug queues and without enabling and changing stresslog entries.
|
mangod9
approved these changes
Oct 28, 2021
Maoni0
approved these changes
Oct 29, 2021
PeterSolMS
requested review from
BrzVlad,
imhameed,
lambdageek,
lateralusX,
marek-safar,
naricc,
SamMonoRT,
thaystg and
vargaz
as code owners
lambdageek
removed request for
vargaz,
marek-safar,
lambdageek,
thaystg,
BrzVlad,
lateralusX,
naricc,
SamMonoRT and
imhameed
PeterSolMS
force-pushed
the
Fix_saved_pinned_plug_index
branch
from
de3f418 to
54ebe83
Compare
This was referenced Nov 29, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We reference entry #0 in the pinned plug queue even if there are no pinned plugs at all and thus the pinned plug queue contains left-over data from the mark phase.
This is #60617 without the saving of the pinned plug queues and without enabling and changing stresslog entries.