Remove PlainPointer, RelativePointer and RelativeFixupPointer #57707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed all uses of PlainPointer - Removed RelativePointer usage from vtable, and MethodDesc logic
Remove fixuppointer.h
davidwrighton
force-pushed
the
RemoveFancyPointers
branch
from
c24d7b0
to
1bc6dd0
Compare
This was referenced Aug 20, 2021
jkoritzinsky
approved these changes
Aug 23, 2021
| @@ -39,7 +39,7 @@ class FieldDesc | |||
| #endif | |||
|
|
|||
| protected: | |||
| RelativePointer<PTR_MethodTable> m_pMTOfEnclosingClass; // This is used to hold the log2 of the field size temporarily during class loading. Yuck. | |||
| PTR_MethodTable m_pMTOfEnclosingClass; // This is used to hold the log2 of the field size temporarily during class loading. Yuck. | |||
There was a problem hiding this comment.
In a future cleanup PR, we should make this field a union to make the "Yuck" comment a little more formalized so we aren't just storing an integer in a "dac-ized" pointer field.
elinor-fung
approved these changes
Aug 23, 2021
Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57706