Fix invalid CodeDom comment generation when a new line starts with a slash #56640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnm2
commented
Jul 30, 2021
src/libraries/System.CodeDom/tests/System/CodeDom/Compiler/CSharpCodeGenerationTests.cs
Outdated
Show resolved
Hide resolved
|
Test failure is #56649 |
|
LGTM, could you please change to SkipOnTargetFrameworks as suggested? |
|
@danmoseley I just realized there's no need to insert a space when generating an ordinary comment (e.g. |
|
Up to you as long as there's tests 🙂 |
jnm2
force-pushed
the
invalid_comment_generation
branch
from
8a28709 to
e8a9331
Compare
|
@danmoseley I noticed that the filename wasn't updated to StringExtensions.cs, so I did that and squashed into my last commit which introduced the file. |
|
Oops thanks |
jnm2
force-pushed
the
invalid_comment_generation
branch
from
546fcb3 to
e590303
Compare
|
GitHub showed that conflicts with main arose in the last week. I used a force push to fix this since no one has reviewed yet. |
danmoseley
reviewed
Aug 9, 2021
src/libraries/System.CodeDom/tests/System/CodeDom/Compiler/VBCodeGenerationTests.cs
Show resolved
Hide resolved
danmoseley
approved these changes
Aug 9, 2021
|
Unrelated failures. Thanks for the fix @jnm2 ! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56267