Add tizen armel build CI for pull request #56281

clamp03 · 2021-07-26T00:02:45Z

With ubuntu-18.04-cross-armel-tizen docker image,
check Tizen_armel build for each pull reqest.

dotnet-issue-labeler · 2021-07-26T00:02:50Z

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

clamp03 · 2021-07-26T00:19:55Z

Currently, it fails before #55789 is merged.

eng/pipelines/coreclr/templates/build-job.yml

ghost · 2021-07-28T13:29:10Z

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

With ubuntu-18.04-cross-armel-tizen docker image,
check Tizen_armel build for each pull reqest.

Author:	clamp03
Assignees:	-
Labels:	`area-Infrastructure-coreclr`, `community-contribution`
Milestone:	-

clamp03 · 2021-08-02T02:31:22Z

eng/pipelines/coreclr/templates/build-job.yml

@@ -210,7 +216,7 @@ jobs:
        displayName: Run CoreCLR Tools unit tests

    # Build native test components
-    - ${{ if ne(parameters.isOfficialBuild, true) }}:
+    - ${{ if and(ne(parameters.isOfficialBuild, true), ne(parameters.archType, 'armel'))}}:


Right. It needs a portable option and some others.
However, as I know, there is no ARMEL environment for test in the CI.
To prevent build failure, I just want to add Tizen ARMEL build this time.
Thank you.

clamp03 · 2021-08-02T02:35:08Z

@safern Could you review this PR? I added Tizen ARMEL Build and it works. However, I think I missed some details. Thank you.

clamp03 · 2021-08-04T03:21:27Z

@safern I think errors are not related to this patch. Could you please review it?

safern · 2021-08-04T04:12:41Z

@safern I think errors are not related to this patch. Could you please review it?

Sorry, @clamp03, I was OOF. Will take a look tomorrow.

clamp03 · 2021-08-04T04:21:45Z

@safern Thank you! :)

clamp03 · 2021-08-09T04:50:03Z

Oops. I pushed the old patch by mistake. Resolved now.

eng/pipelines/coreclr/templates/build-job.yml

safern · 2021-08-09T18:21:06Z

This is currently just adding support for the coreclr build job template. Do we want to protect the dotnet/runtime end-to-end build? i.e, building all the subsets and producing a runtime pack for tizen?

clamp03 · 2021-08-10T01:33:41Z

This is currently just adding support for the coreclr build job template. Do we want to protect the dotnet/runtime end-to-end build? i.e, building all the subsets and producing a runtime pack for tizen?

I think the others are handled by arm32 (hardfp) build.
If armel build fails again, I will update it next time.
Thank you.

clamp03 · 2021-10-05T06:43:26Z

I think failures are not related to this PR. Could you please review and merge?
Thank you.

jkotas · 2021-10-05T15:02:36Z

@safern Could you please take final look and merge if it looks good?

safern · 2021-10-06T22:09:04Z

eng/pipelines/common/platform-matrix.yml

+      jobTemplate: ${{ parameters.jobTemplate }}
+      helixQueuesTemplate: ${{ parameters.helixQueuesTemplate }}
+      variables: ${{ parameters.variables }}
+      osGroup: Linux


Last question. It is currently showing up on the UI as Linux armel as the name, do we want it to be that or Tizen armel to make it more clear?

Yes, it would be nice to have more distinct name for this (Tizen armel).

Thank you for the review. I updated the name on the UI.

@safern @jkotas I think test failures are not caused by this PR. Please review again. Thank you.

Could you please review it?

safern · 2021-10-12T05:58:50Z

@clamp03 I see that there is an error on the build coreclr runtime step:

/__w/1/s/eng/native/init-distro-rid.sh: line 44: [: missing `]'
/__w/1/s/eng/native/init-distro-rid.sh: line 44: tizen: command not found

Also, I see that in that step the distro rid is resolved as: __DistroRid: tizen.6.5.0-armel and in Build managed product components and packages step it is resolved as: __DistroRid: linux-armel

I think we need to fix this?

clamp03 · 2021-10-12T06:42:34Z

@safern Thank you for the review

@clamp03 I see that there is an error on the build coreclr runtime step:
/__w/1/s/eng/native/init-distro-rid.sh: line 44: [: missing `]'
/__w/1/s/eng/native/init-distro-rid.sh: line 44: tizen: command not found

Sorry. I missed error messages.
This is not related to this Patch. It is because of #59178.
I fixed and added a patch in this PR.

Also, I see that in that step the distro rid is resolved as: __DistroRid: tizen.6.5.0-armel and in Build managed product components and packages step it is resolved as: __DistroRid: linux-armel

I think we need to fix this?

In our Tizen, we use clr and libs.native with portable build for tizen and the others for common linux-armel.
So I think we don't need to fix this.

eng/native/init-distro-rid.sh

clamp03 · 2021-10-13T05:18:45Z

An error (multiline comment) in runtime (CoreCLR GCC Product BUild Linux x86 Checked) is not related to this PR.
It is by #58727. There is \ in the end of comment line 10915. I think it is better to fix by the author of PR 58727 in other PR. CC @benjamin-hodgson

runtime/src/coreclr/jit/morph.cpp

Lines 10914 to 10916 in 80e843f

    
           //   op1   op2   ==>   tree 
        
           //    |     |          /   \ 
        
           //    x     y         x     y

@safern @jkotas Could you please review this PR and merge if it is good?

am11 · 2021-10-13T08:49:29Z

I pushed a commit to fix gcc build in #60328 (period after trailing \ on single-line comment line is how we fixed issues in dotnet/coreclr in morph.cpp and other places).

safern · 2021-10-13T16:23:18Z

@hoyosjs @jkoritzinsky it seems like the GCC build is broken?

safern · 2021-10-13T16:29:17Z

It seems like that break was fixed on: #60333.

safern · 2021-10-13T16:29:56Z

Thanks, @clamp03 🎉

ghost added the community-contribution Indicates that the PR has been added by a community member label Jul 26, 2021

clamp03 mentioned this pull request Jul 26, 2021

[Tizen] CI for pull requests #2394

Closed

clamp03 force-pushed the tizen-armel-build-ci branch from f2b2066 to 4156526 Compare July 26, 2021 00:17

am11 reviewed Jul 26, 2021

View reviewed changes

eng/pipelines/coreclr/templates/build-job.yml Outdated Show resolved Hide resolved

karelz mentioned this pull request Jul 26, 2021

[HTTP/3] Test failure ResponseCancellation_ServerReceivesCancellation #56194

Closed

clamp03 force-pushed the tizen-armel-build-ci branch from 4156526 to 99a316b Compare July 27, 2021 04:41

karelz mentioned this pull request Jul 28, 2021

Test failure: ConnectWithCertificateForDifferentName_Throws - NullReferenceException #56454

Closed

eerhardt added the area-Infrastructure-coreclr label Jul 28, 2021

clamp03 mentioned this pull request Jul 30, 2021

Fix crossgen2 build on Tizen #55789

Merged

clamp03 force-pushed the tizen-armel-build-ci branch from 99a316b to 72f1373 Compare July 31, 2021 03:53

am11 mentioned this pull request Jul 31, 2021

[armel] Broken build #56623

Closed

clamp03 commented Aug 2, 2021

View reviewed changes

clamp03 force-pushed the tizen-armel-build-ci branch 2 times, most recently from 2d50683 to 1a03b2a Compare August 3, 2021 06:28

clamp03 force-pushed the tizen-armel-build-ci branch from 1a03b2a to e00cba4 Compare August 9, 2021 02:31

safern reviewed Aug 9, 2021

View reviewed changes

eng/pipelines/coreclr/templates/build-job.yml Outdated Show resolved Hide resolved

clamp03 force-pushed the tizen-armel-build-ci branch 2 times, most recently from 54a6181 to 5259807 Compare August 10, 2021 01:32

clamp03 force-pushed the tizen-armel-build-ci branch from 5259807 to 1f5fb96 Compare August 10, 2021 01:55

safern reviewed Oct 6, 2021

View reviewed changes

This was referenced Oct 7, 2021

System.Tests.TimeZoneInfoTests.TestWindowsNlsDisplayNames is failing on rolling builds #60119

Closed

System.Runtime.Serialization.Xml.Tests failed #59926

Closed

clamp03 force-pushed the tizen-armel-build-ci branch from fac10bf to 49699d6 Compare October 12, 2021 06:34

am11 reviewed Oct 12, 2021

View reviewed changes

eng/native/init-distro-rid.sh Outdated Show resolved Hide resolved

clamp03 added 9 commits October 13, 2021 09:04

Add tizen amrel build CI

23f2ce1

Fix some errors

af745ec

Fix platform-matrix.yml

aa51bab

Skip tests for tizen-armel

758a165

Fix typo

1d9c749

Introduce a paramter to skip tests

14c32c7

Update osGroup to Tizen

4f97445

Fix an error

fa29dd5

Update fix

aef39e1

clamp03 force-pushed the tizen-armel-build-ci branch from 49699d6 to aef39e1 Compare October 13, 2021 00:05

akoeplinger mentioned this pull request Oct 13, 2021

Fix build with clang 13 #60328

Merged

safern approved these changes Oct 13, 2021

View reviewed changes

safern merged commit 0cb73e8 into dotnet:main Oct 13, 2021

clamp03 deleted the tizen-armel-build-ci branch October 14, 2021 01:13

ghost locked as resolved and limited conversation to collaborators Nov 13, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tizen armel build CI for pull request #56281

Add tizen armel build CI for pull request #56281

clamp03 commented Jul 26, 2021

dotnet-issue-labeler bot commented Jul 26, 2021

clamp03 commented Jul 26, 2021

ghost commented Jul 28, 2021

clamp03 Aug 2, 2021

clamp03 commented Aug 2, 2021

clamp03 commented Aug 4, 2021

safern commented Aug 4, 2021

clamp03 commented Aug 4, 2021

clamp03 commented Aug 9, 2021

safern commented Aug 9, 2021

clamp03 commented Aug 10, 2021 •

edited

Loading

clamp03 commented Oct 5, 2021

jkotas commented Oct 5, 2021 •

edited

Loading

safern Oct 6, 2021

jkotas Oct 7, 2021

clamp03 Oct 7, 2021

clamp03 Oct 7, 2021

clamp03 Oct 12, 2021

safern commented Oct 12, 2021 •

edited

Loading

clamp03 commented Oct 12, 2021

clamp03 commented Oct 13, 2021 •

edited

Loading

am11 commented Oct 13, 2021

safern commented Oct 13, 2021

safern commented Oct 13, 2021

safern commented Oct 13, 2021

Add tizen armel build CI for pull request #56281

Add tizen armel build CI for pull request #56281

Conversation

clamp03 commented Jul 26, 2021

dotnet-issue-labeler bot commented Jul 26, 2021

clamp03 commented Jul 26, 2021

ghost commented Jul 28, 2021

clamp03 Aug 2, 2021

Choose a reason for hiding this comment

clamp03 commented Aug 2, 2021

clamp03 commented Aug 4, 2021

safern commented Aug 4, 2021

clamp03 commented Aug 4, 2021

clamp03 commented Aug 9, 2021

safern commented Aug 9, 2021

clamp03 commented Aug 10, 2021 • edited Loading

clamp03 commented Oct 5, 2021

jkotas commented Oct 5, 2021 • edited Loading

safern Oct 6, 2021

Choose a reason for hiding this comment

jkotas Oct 7, 2021

Choose a reason for hiding this comment

clamp03 Oct 7, 2021

Choose a reason for hiding this comment

clamp03 Oct 7, 2021

Choose a reason for hiding this comment

clamp03 Oct 12, 2021

Choose a reason for hiding this comment

safern commented Oct 12, 2021 • edited Loading

clamp03 commented Oct 12, 2021

clamp03 commented Oct 13, 2021 • edited Loading

am11 commented Oct 13, 2021

safern commented Oct 13, 2021

safern commented Oct 13, 2021

safern commented Oct 13, 2021

clamp03 commented Aug 10, 2021 •

edited

Loading

jkotas commented Oct 5, 2021 •

edited

Loading

safern commented Oct 12, 2021 •

edited

Loading

clamp03 commented Oct 13, 2021 •

edited

Loading