Refactor runtime-specific logic out of CustomAttributeData #55870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
requested review from
lambdageek,
marek-safar,
thaystg and
vargaz
as code owners
CustomAttributeData is meant to be abstract base class of reflection object model. Move the runtime-specific part into a separate RuntimeCustomAttributeData type.
jkotas
force-pushed
the
customattributedata
branch
from
231025c
to
c1bb326
Compare
jkotas
commented
Jul 17, 2021
| bool first = true; | ||
|
|
||
| int count = ConstructorArguments.Count; | ||
| IList<CustomAttributeTypedArgument> constructorArguments = ConstructorArguments; |
There was a problem hiding this comment.
Cache in locals to avoid redundant interface calls.
jkotas
commented
Jul 17, 2021
| @@ -79,6 +87,11 @@ public override string ToString() | |||
|
|
|||
| #region Public Members | |||
| public virtual Type AttributeType => Constructor.DeclaringType!; | |||
|
|
|||
| // Expected to be overriden | |||
| public virtual ConstructorInfo Constructor => null!; | |||
There was a problem hiding this comment.
This matches the existing Mono behavior. The existing CoreCLR behavior is to throw NullReferenceException in some of these.
Wraith2
reviewed
Jul 17, 2021
src/libraries/System.Private.CoreLib/src/System/Reflection/CustomAttributeData.cs
Show resolved
Hide resolved
jkotas
force-pushed
the
customattributedata
branch
from
74a6760
to
00aa646
Compare
marek-safar
approved these changes
Jul 17, 2021
src/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeCustomAttributeData.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Reflection/CustomAttributeNamedArgument.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Reflection/CustomAttributeNamedArgument.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Reflection/CustomAttributeNamedArgument.cs
Outdated
Show resolved
Hide resolved
…tomAttributeNamedArgument.cs Co-authored-by: Marek Safar <marek.safar@gmail.com>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CustomAttributeData is meant to be abstract base class of reflection object model. Move the runtime-specific part
into a separate RuntimeCustomAttributeData type.
This avoids bugs like #55726 by construction.