Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Misc follow up improvements for workloads testing #55647

Merged
merged 7 commits into from
Jul 15, 2021
Merged

[wasm] Misc follow up improvements for workloads testing #55647

merged 7 commits into from
Jul 15, 2021

Conversation

radical
Copy link
Member

@radical radical commented Jul 14, 2021 •
edited
Loading

  • Addresses some suggestions from Larry Ewing
  • And fixes emcc cache-info messages breaking the build because get are on stderr, and get logged as warnings.
  • Improve logging a bit to track EmccCompile's parallel emcc output
  • Change Emscripten version mismatch to a warning

@radical radical added the arch-wasm WebAssembly architecture label Jul 14, 2021
@ghost
Copy link

ghost commented Jul 14, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
Author: radical
Assignees: -
Labels:

arch-wasm
Milestone: -

@radical
[wasm] Move UseMonoRuntime=true to WasmApp.props
eb24b84
@radical
Move workloads installation for testing bits to
92a0ac8 
.. `src/libraries/workloads-testing.targets`.
@radical
[wasm] EmccCompile: don't log stderr messages as warnings
975a3f0 
emcc emits some (debug?) messages on stderr too, which are not always
errors. Emitting them as warning can be break the build too, when
running with warningsAsErrors .
@radical
[wasm] Fix helix work item prefix
b6e098e
@lewing
Copy link
Member

lewing commented Jul 14, 2021

/azp run runtime,runtime-staging

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@lewing
Copy link
Member

lewing commented Jul 15, 2021

runtime (CoreCLR Product Build Linux arm64 checked)

Starting: Publish product build
==============================================================================
Task         : Publish build artifacts
Description  : Publish build artifacts to Azure Pipelines or a Windows file share
Version      : 1.186.0
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/publish-build-artifacts
==============================================================================
Async Command Start: Upload Artifact
Async Command End: Upload Artifact
##[error]Network is unreachable
Finishing: Publish product build

@lewing
Copy link
Member

lewing commented Jul 15, 2021

Failure was unrelated

@lewing lewing merged commit bcc7944 into dotnet:main Jul 15, 2021
@radical radical deleted the wasm-workloads-followup branch July 15, 2021 21:47
@ManickaP ManickaP mentioned this pull request Jul 20, 2021
Merged
@karelz karelz mentioned this pull request Jul 20, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lewing lewing lewing approved these changes

@akoeplinger akoeplinger Awaiting requested review from akoeplinger akoeplinger is a code owner

@marek-safar marek-safar Awaiting requested review from marek-safar

Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radical @lewing