Skip to content

exclude UTF8 string marshallers from cg2 #55624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 15, 2021
Merged

exclude UTF8 string marshallers from cg2 #55624

merged 3 commits into from
Jul 15, 2021

Conversation

mangod9
Copy link
Member

@mangod9 mangod9 commented Jul 14, 2021

Fixes #51189

@dotnet/crossgen-contrib

@mangod9 mangod9 requested a review from MichalStrehovsky July 14, 2021 06:53
MichalStrehovsky
MichalStrehovsky reviewed Jul 14, 2021
View reviewed changes
Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise!

@mangod9
keep unicodestringmarshaller
3d9cb77 
The non-pinned cases which are not supported will throw
@mangod9 mangod9 changed the title exclude UTF8 and Unicode string marshallers from cg2 exclude UTF8 string marshallers from cg2 Jul 14, 2021
@davidwrighton
Copy link
Member 

                            Context.GetHelperEntryPoint("InteropHelpers", "CoTaskMemFree")));

This block needs the #if READYTORUN and throw NotSupportedException change as well.

Refers to: src/coreclr/tools/Common/TypeSystem/Interop/IL/Marshaller.cs:1609 in 3d9cb77. [](commit_id = 3d9cb77, deletion_comment = False)

davidwrighton
davidwrighton requested changes Jul 14, 2021
View reviewed changes
Copy link
Member

@davidwrighton davidwrighton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@mangod9
excluding one non-r2r case
936e6ba 
All calls to InteropHelpers should now be under !READYTORUN
@mangod9
Copy link
Member Author

mangod9 commented Jul 15, 2021

windows x86 release Runtime_Debug is actually green, but the checks doesnt seem to have the updated status.

@mangod9 mangod9 merged commit 54c3db5 into dotnet:main Jul 15, 2021
@mangod9 mangod9 deleted the removemarshallers branch July 15, 2021 03:22
@ManickaP ManickaP mentioned this pull request Jul 20, 2021
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas left review comments

@MichalStrehovsky MichalStrehovsky MichalStrehovsky left review comments

@AntonLapounov AntonLapounov AntonLapounov left review comments

@davidwrighton davidwrighton davidwrighton approved these changes

Assignees
No one assigned
Labels
area-crossgen2-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code generation failure when using UnmanagedType.LPUTF8Str in the interop definition inside System.Private.CoreLib.
5 participants
@mangod9 @davidwrighton @jkotas @MichalStrehovsky @AntonLapounov