Use init rather than ms extension syntax #55475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
|
With decltype, it apparently didn't clear head/tail or re-instantiated the list which was corrupting crossgen2. I have added a debug-only init method to simplify things. |
am11
changed the title
|
@am11 would doing a placement new + decltype work instead of adding the Init method? Something like the following: new (&ig->igBlocks) decltype(ig->igBlocks)(emitComp->getAllocator(CMK_LoopOpt))
|
am11
force-pushed
the
fix/gcc-build
branch
2 times, most recently
from
f3f14dd to
8e60c0d
Compare
|
Indeed, it is much cleaner. I was too pressed on making explicit ctor work with decltype, didn't thought of other (size_t) ctros. :) |
|
Looks like MSVC didn't resolve the correct type with decltype (it is resolving the type of Allocator rather than list<T,Allocator>). |
|
Reverted to init approach for now, which makes all compilers happy. :) |
BruceForstall
approved these changes
Jul 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gcc build.
Clang also gives the error as gcc when calling ctor function explicitly, but clang emits warning with
-fms-extensions:gcc just does not support this extension (even with
-fms-extensions). So lets fix it by rewriting it in ISO C++ syntax.cc @BruceForstall, @janvorli