Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for a couple of Microsoft.XmlSerializer.Generator issues #55427

Merged
merged 2 commits into from
Jul 13, 2021
Merged

Fix for a couple of Microsoft.XmlSerializer.Generator issues #55427

merged 2 commits into from
Jul 13, 2021

Conversation

HongGit
Copy link
Contributor

@HongGit HongGit commented Jul 9, 2021

Issue #597
Issue #40511

mconnew
mconnew requested changes Jul 9, 2021
View reviewed changes
Copy link
Member

@mconnew mconnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just change the generated file name and it's good.

@HongGit HongGit marked this pull request as ready for review July 12, 2021 20:35
@stephentoub stephentoub merged commit aaade77 into dotnet:main Jul 13, 2021
@HongGit HongGit deleted the dev/hongli/work branch July 14, 2021 21:27
@ManickaP ManickaP mentioned this pull request Jul 20, 2021
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mconnew mconnew mconnew approved these changes

@StephenMolloy StephenMolloy StephenMolloy approved these changes

Assignees
No one assigned
Labels
area-Serialization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HongGit @mconnew @StephenMolloy @stephentoub