Avoid nullref while trying to throw a more helpful exception. #55316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
reviewed
Jul 8, 2021
Comment on lines
364
to
365
| var oldType = (oldObj != null) ? DataContract.GetClrTypeFullName(oldObj.GetType()) : "unknown type"; | ||
| var newType = (newObj != null) ? DataContract.GetClrTypeFullName(newObj.GetType()) : "unknown type"; |
There was a problem hiding this comment.
Nit:
Suggested change
| var oldType = (oldObj != null) ? DataContract.GetClrTypeFullName(oldObj.GetType()) : "unknown type"; | |
| var newType = (newObj != null) ? DataContract.GetClrTypeFullName(newObj.GetType()) : "unknown type"; | |
| string oldType = (oldObj != null) ? DataContract.GetClrTypeFullName(oldObj.GetType()) : "unknown type"; | |
| string newType = (newObj != null) ? DataContract.GetClrTypeFullName(newObj.GetType()) : "unknown type"; |
Also, does "unknown type" need to come from a resx?
HongGit
approved these changes
Jul 12, 2021
mconnew
requested changes
Jul 12, 2021
There was a problem hiding this comment.
Please make the changes that @stephentoub requested. "Unknown Type" should be a string resource so that it gets translated.
mconnew
approved these changes
Jul 15, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid nullref while trying to throw a more helpful exception.
The method checking for referential surrogates during deserialization
(
ReplaceDeserializedObject) wants to throw a helpful exception whenit can't fix up references post-type-substitution. In order to actually be
helpful, avoid nullref-ing when one of the objects involved in the
replacement is null. Simply use the term "unknown type" instead.
Fixes #41465