Use RetryHelper with AIA tests #55230
Conversation
The AIA tests depend on many external factors including the underlying operation system, network, and the resources available on the system. To accomodate this we will re-run the tests to improve reliability.
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks Issue DetailsThe AIA tests depend on many external factors including the underlying PR is best reviewed ignoring whitespace. Closes #49014.
|
| Assert.Equal(2, chain.ChainElements.Count); | ||
| } | ||
| RetryHelper.Execute(() => { | ||
| CertificateAuthority.BuildPrivatePki( |
There was a problem hiding this comment.
On the one hand, not capturing closures is nice. On the other, recreating the PKI pieces and listener and such feels like it could be hiding bugs.. so we probably only want to retry the inner portion of the usings (though moving ChainHolder inside the retry so we're not introducing a "works on the second call to Build" bug)
There was a problem hiding this comment.
Eh, I'm wary of making that even more non-deterministic based on my experience last time from the AIA tests. But those tests for sensitive to execution time, so maybe I am applying the wrong logic. I suppose it can't hurt to try the more narrow way first.
ghost
locked as resolved and limited conversation to collaborators
The AIA tests depend on many external factors including the underlying
operation system, network, and the resources available on the system.
To accomodate this we will re-run the tests to improve reliability.
PR is best reviewed ignoring whitespace.
Closes #49014.