Skip to content

Override the APM methods on AsyncWindowsFileStreamStrategy. #55203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 14, 2021
Merged

Override the APM methods on AsyncWindowsFileStreamStrategy. #55203

merged 4 commits into from
Jul 14, 2021

Conversation

teo-tsirpanis
Copy link
Contributor

Closes #55172.

@ghost
Copy link

ghost commented Jul 6, 2021

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Closes #55172.

Author: teo-tsirpanis
Assignees: -
Labels:

area-System.IO
Milestone: -

@stephentoub stephentoub requested a review from adamsitnik July 6, 2021 20:22
stephentoub
stephentoub reviewed Jul 9, 2021
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my comments, LGTM. Thanks.

@teo-tsirpanis
Copy link
Contributor Author

OK, feedback is addressed.

@stephentoub stephentoub merged commit 95044fd into dotnet:main Jul 14, 2021
@stephentoub
Copy link
Member

Thanks!

@teo-tsirpanis teo-tsirpanis deleted the async-windows-io-apm branch July 14, 2021 19:29
@adamsitnik adamsitnik added this to the 6.0.0 milestone Jul 19, 2021
@ManickaP ManickaP mentioned this pull request Jul 20, 2021
Merged
@karelz karelz mentioned this pull request Jul 27, 2021
Closed
@GSPP
Copy link

GSPP commented Aug 15, 2021

This was a pretty severe bug. I just had an idea on how this could be avoided in the future: Write a reflection-based test that makes sure that all Stream read and write methods are overridden in all BCL classes.

@ghost ghost locked as resolved and limited conversation to collaborators Sep 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@adamsitnik adamsitnik Awaiting requested review from adamsitnik

Assignees
No one assigned
Labels
area-System.IO
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

FileStream.BeginRead/Write with useAsync no longer use overlapped I/O
4 participants
@teo-tsirpanis @stephentoub @GSPP @adamsitnik