Skip to content

[release/6.0-preview6][Mono] Condition Workload AOT import to be osx only #55091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lewing
Copy link
Member

@lewing lewing commented Jul 2, 2021

Backport of #55040 [Mono] Condition Workload AOT import to be osx only

If we don't, then the aot packs will be imported on Windows when running an iOS offline build

Fixes #54944

Customer Impact

Avoids incorrect imports that will cause problems on platforms other than osx.

Testing

Manual testing.

Risk

Low, it add restrictions to imported properties

@lewing lewing added the Servicing-consider Issue for next servicing release review label Jul 2, 2021
@lewing lewing requested a review from marek-safar as a code owner July 2, 2021 17:21
@ghost ghost added the area-System.Net label Jul 2, 2021
@ghost
Copy link

ghost commented Jul 2, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details
Author: lewing
Assignees: -
Labels:

Servicing-consider, area-System.Net

Milestone: -

@lewing lewing force-pushed the backport-55040-to-preview6 branch from fddaab4 to ce9815e Compare July 2, 2021 17:24
@lewing lewing force-pushed the backport-55040-to-preview6 branch from ce9815e to 03fe89c Compare July 2, 2021 17:25
@lewing lewing requested a review from steveisok July 2, 2021 17:26
@lewing lewing changed the title Backport #55040 to preview6 [release/6.0-preview6][Mono] Condition Workload AOT import to be osx only Jul 2, 2021
@steveisok steveisok added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jul 2, 2021
@steveisok
Copy link
Member

This change was approved in an email.

@steveisok steveisok merged commit 770d630 into dotnet:release/6.0-preview6 Jul 2, 2021
@lewing lewing deleted the backport-55040-to-preview6 branch July 2, 2021 21:29
@karelz karelz added this to the 6.0.0 milestone Jul 15, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants