-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the "do not zero-extend setcc" optimization to lower #53778
Merged
kunalspathak
merged 4 commits into
dotnet:main
from
SingleAccretion:Move-Relop-Opt-To-Lower
Jul 13, 2021
Merged
Move the "do not zero-extend setcc" optimization to lower #53778
kunalspathak
merged 4 commits into
dotnet:main
from
SingleAccretion:Move-Relop-Opt-To-Lower
Jul 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jun 6, 2021
It is XARCH-specific and moving it eliminates questionable code that is trying to compensate for CSE changing the store.
SingleAccretion
force-pushed
the
Move-Relop-Opt-To-Lower
branch
from
June 6, 2021 04:03
8018674
to
8014879
Compare
Any changes in libraries.pmi for xarch/armarch? |
For XARCH, x64 (also see above):
No diffs for ARMARCH as expected. |
@kunalspathak @dotnet/jit-contrib PTAL. |
kunalspathak
approved these changes
Jul 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I am re-running the failed jobs just to be sure.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is XARCH-specific and moving it eliminates questionable code that is trying to compensate for CSE changing the store. Also removes a case where a node that actually produces
TYP_INT
has a small type in HIR.Also, use strongly-typed trees (and related helpers) for the lowering functions that deal with
GT_STOREIND
to improve the clarity of code.I was not looking for CQ improvements with this change, but there were, apparently, some cases that morph missed:
Windows x64 diffs
Windows x86 diffs
As expected, this is a no-diff change for ARMARCH - verified via replaying
linux-arm
andlinux-arm64
collections.Depending on the merge order, this might conflict with #53667 (that's fine, just mentioning it for completeness).