Skip to content

Remove System.Text.Json's DynamicDependencies on Collections.Immutable #53317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2021

Conversation

eerhardt
Copy link
Member

This saves roughly 28 KB compressed in a default blazor wasm app.

Fix #53256

This saves roughly 28 KB compressed in a default blazor wasm app.

Fix dotnet#53256
@ghost
Copy link

ghost commented May 26, 2021

Tagging subscribers to this area: @eiriktsarpalis, @layomia
See info in area-owners.md if you want to be subscribed.

Issue Details

This saves roughly 28 KB compressed in a default blazor wasm app.

Fix #53256

Author: eerhardt
Assignees: -
Labels:

area-System.Text.Json

Milestone: -

@eerhardt eerhardt added the size-reduction Issues impacting final app size primary for size sensitive workloads label May 26, 2021
@ghost
Copy link

ghost commented May 26, 2021

Tagging subscribers to 'size-reduction': @eerhardt, @SamMonoRT, @marek-safar, @CoffeeFlux
See info in area-owners.md if you want to be subscribed.

Issue Details

This saves roughly 28 KB compressed in a default blazor wasm app.

Fix #53256

Author: eerhardt
Assignees: -
Labels:

area-System.Text.Json, size-reduction

Milestone: -

Copy link
Contributor

@layomia layomia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eerhardt eerhardt merged commit fe67c3f into dotnet:main May 27, 2021
@eerhardt eerhardt deleted the RemoveJsonImmutableReference branch May 27, 2021 20:25
@ghost ghost locked as resolved and limited conversation to collaborators Jun 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Text.Json size-reduction Issues impacting final app size primary for size sensitive workloads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove System.Text.Json's DynamicDependencies on Collections.Immutable
3 participants