Keep looking up derived chain for Property.Get if it doesn't exist. #52509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HongGit
approved these changes
May 11, 2021
mconnew
approved these changes
May 12, 2021
StephenMolloy
force-pushed
the
Ser-Overridden-Getless-Prop
branch
from
21cabff
to
d15494e
Compare
mconnew
reviewed
Jul 9, 2021
| // getter at this level of inheritance. If that's the case, we need to look | ||
| // up the chain to find the right PropertyInfo for the getter. | ||
| if (memberInfo is PropertyInfo propInfo && propInfo.GetMethod == null) | ||
| { |
There was a problem hiding this comment.
What happens if a base type has a property called Foo and the derived type has a method called Foo? GetMember would return the MethodInfo for the dervived Foo method and this code won't search the base type for the property.
There was a problem hiding this comment.
Crikey! But as we've talked about before, 'hidden' members are a mess in the serializers right now. This would fall under the broader work we need to do in #53051.
mconnew
reviewed
Jul 9, 2021
| // The property name is a match. It might be an override, or | ||
| // it might be hiding. Either way, check to see if the derived | ||
| // property has a getter that is useable for serialization. | ||
| if (info.GetMethod != null && !info.GetMethod!.IsPublic | ||
| && memberInfoToBeReplaced is PropertyInfo |
There was a problem hiding this comment.
would info.GetMethod?.IsPublic be more concise?
mconnew
approved these changes
Jul 9, 2021
HongGit
approved these changes
Jul 12, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep looking up derived chain for Property.Get.
When dealing with a derived type, we have code that looks up
the derived chain looking for property getters if it doesn't
exist directly on the class being serialized. This code was tripping
up when a class in the chain declared a setter for the property
without a getter though. In this case, we should keep going
up the chain looking for a getter instead of failing.
Fixes #36181 and #38025