Separate GetResourceString method with defaultString value.

[marek-safar]

It's not used in Release build and it injects ununsed null value to every callsite

[ghost]

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

[stephentoub]

It's not used in Release build

Is this true? e.g.

runtime/src/libraries/System.ComponentModel.TypeConverter/src/System/Timers/TimersDescriptionAttribute.cs

Line 26 in 79ae74f

internal TimersDescriptionAttribute(string description, string defaultValue) : base(SR.GetResourceString(description, defaultValue)) { }

runtime/src/libraries/System.Private.CoreLib/src/System/Diagnostics/StackTrace.cs

Line 206 in 79ae74f

string word_At = SR.GetResourceString(nameof(SR.Word_At), defaultString: "at");

runtime/src/libraries/Microsoft.CSharp/src/Microsoft/CSharp/RuntimeBinder/Errors/ErrorFacts.cs

Line 209 in 79ae74f

return SR.GetResourceString(idStr, idStr);

[stephentoub]

That said, splitting it seems fine. Most assemblies don't need the latter.

[stephentoub]

This creates a difference from its .vb counterpart.

[marek-safar]

Does it matter? The only place where it's used is in archived Microsoft.VisualBasic.Core library

[stephentoub]

I don't know that it matters, but I wanted to call it out.
cc: @tarekgh

[tarekgh]

The only place where it's used is in archived Microsoft.VisualBasic.Core library

that is right. if this change is not affecting Microsoft.VisualBasic.Core, it should be ok. But should we just keep C# and VB match for consistency?

[marek-safar]

I'd rather not touch Microsoft.VisualBasic.Core code and I don't think the consistency matters here.

[marek-safar]

Is this true? e.g.

runtime/src/libraries/System.ComponentModel.TypeConverter/src/System/Timers/TimersDescriptionAttribute.cs

The value is always null. I intentionally didn't want to mix the clean up with PR

runtime/src/libraries/System.Private.CoreLib/src/System/Diagnostics/StackTrace.cs

That's the only case

runtime/src/libraries/Microsoft.CSharp/src/Microsoft/CSharp/RuntimeBinder/Errors/ErrorFacts.cs

The assembly is archived so I didn't update the code (it's not worth it)

The only cases where it's really used in Release build are StackTrace.cs and System.ComponentModel.Annotations library if that's what you were asking for.

[stephentoub]

if that's what you were asking for

I was mainly questioning the assertion.