Reenable Android.Device_Emulator.Aot.Test.csproj #50332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue DetailsCloses #49757
|
akoeplinger
force-pushed
the
akoeplinger-patch-1
branch
from
75361ab to
91f4f4e
Compare
This was referenced Mar 31, 2021
steveisok
approved these changes
Mar 31, 2021
safern
reviewed
Mar 31, 2021
| @@ -68,6 +68,11 @@ | |||
| <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Text.RegularExpressions\tests\System.Text.RegularExpressions.Tests.csproj" /> | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup Condition="'$(TargetOS)' == 'Android' and '$(TargetArchitecture)' == 'x86'"> | |||
| <!-- https://github.com/dotnet/runtime/issues/50493 --> | |||
| <FunctionalTestExclusions Include="$(RepoRoot)\src\tests\FunctionalTests\Android\Device_Emulator\AOT\Android.Device_Emulator.Aot.Test.csproj" /> | |||
There was a problem hiding this comment.
Curious why didn't we choose to use ProjectExclusions for this case?
There was a problem hiding this comment.
Hmm it felt like a good idea to separate from the normal unit tests but now that I look again it's probably unnecessary. Will merge to unblock the tests and rename this in a follow-up PR.
akoeplinger
added a commit
that referenced
this pull request
Mar 31, 2021
Follow up from feedback in #50332
stephentoub
pushed a commit
that referenced
this pull request
Apr 1, 2021
Follow up from feedback in #50332
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #49757