-
Notifications
You must be signed in to change notification settings - Fork 5k
Update ActivityUserGuide.md #49818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ActivityUserGuide.md #49818
Conversation
Refer activity guide to the official docs dotnet/docs#23313 is bringing more enhancements shortly
Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti Issue DetailsRefer activity guide to the official docs dotnet/docs#23313 is bringing more enhancements shortly
|
Once that's merged we'll delete this document? Assuming it'll actually be merged shortly, we could just delete this doc now, no? |
I would suggest deleting this doc and move any missing information to the new document. Keeping that with the new comment in the top will force the reader read this doc while they don't need to in most of the cases. Also, having one place for the doc would be easier pointing users to. |
@tarekgh - Are you volunteering to do the work? : ) |
That is fine to keep the doc for now till we move the needed contents to the other place.
Not in the current time but I wouldn't mind help in that in the future. I am simply curious why we need to keep the usage of DiagnosticSource with Activity? We need to discourage users from that and move to ActivitySource I guess. I am approving this PR and we can look at refactoring in other time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
While I wouldn't encourage most users to do it, there are still some scenarios that can't be accomplished any other way. We also haven't yet replicated every relevant piece of useful guidance onto the official docs for the people who aren't using DiagnosticSource with Activity. I am making a bet (and perhaps it is a bad bet) that the people who find this doc and choose to keep reading it after seeing the obsoletion warning at best will learn something useful and at worst they'll decide it was a waste of their time to read and forget what they read in it. |
Refer activity guide to the official docs
dotnet/docs#23313 is bringing more enhancements shortly