Skip to content

Big-endian test case fixes: System.Reflection #49693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Big-endian test case fixes: System.Reflection #49693

merged 1 commit into from
Mar 17, 2021

Conversation

uweigand
Copy link
Contributor

  • Fix endian assumptions in tests operating on PE headers / IL metadata
    (this is always encoded in little-endian byte order)

  • Fix expected result for BlobReader test (always little-endian)

  • Fix expected results for GUID tests

* Fix endian assumptions in tests operating on PE headers / IL metadata
  (this is always encoded in little-endian byte order)

* Fix expected result for BlobReader test (always little-endian)

* Fix expected results for GUID tests
@stephentoub stephentoub merged commit 66e665f into dotnet:main Mar 17, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Apr 16, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants