Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we can evolve IO.Pipelines package #40212

Merged
1 commit merged into from
Jul 31, 2020
Merged

Conversation

ericstj
Copy link
Member

@ericstj ericstj commented Jul 31, 2020

No description provided.

@ericstj
Copy link
Member Author

ericstj commented Jul 31, 2020

Essentially we should never be using InboxOnTargetFramework any more, since this freezes our API by only permitting it to come from the framework itself. Since 2.0 added conflict resolution we should use that to evolve libraries both in framework and package, letting whichever is newest win.

@safern
Copy link
Member

safern commented Jul 31, 2020

Moving forward should we make the default validation, validate that we don't freeze APIs, so that we don't have to add this suppression by default and if for some reason we need to freeze APIs by adding InboxOnTargetFramework then suppress the "new" validation?

@ericstj
Copy link
Member Author

ericstj commented Jul 31, 2020

That effectively just means to remove the validation of inbox. We should do that. dotnet/arcade#5873

@ghost
Copy link

ghost commented Jul 31, 2020

Hello @ericstj!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 62881e5 into dotnet:master Jul 31, 2020
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants