WASM: Enable System.Threading.Tasks.Dataflow tests #38723
Conversation
With the recent async Tasks fix we can now skip just a handful of tests to get the testsuite to passing: `Tests run: 317, Errors: 0, Failures: 0, Skipped: 18. Time: 18.780363s`
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging subscribers to this area: @tarekgh |
| @@ -1121,6 +1121,7 @@ public async Task TestReceiveAsync_ManyInOrder() | |||
| } | |||
|
|
|||
| [Fact] | |||
| [PlatformSpecific(~TestPlatforms.Browser)] // uses a lot of stack | |||
There was a problem hiding this comment.
Were this and TestOutputAvailableAsync_LongSequence the only ones to use a lot of the stack? Were there other indications that led to skipping the test with PlatformSpecific rather than ConditionalFact?
There was a problem hiding this comment.
Yeah and to be honest they didn't really show up during my testing on wasm but from a conversation I saw on Slack where @BrzVlad recommended we disable this test when using the interpreter so I figured wasm is in the same boat: https://xamarinhq.slack.com/archives/C03CELHQQ/p1593621506218500 😄
ghost
locked as resolved and limited conversation to collaborators
With the recent async Tasks fix we can now skip just a handful of tests to get the testsuite to passing:
Tests run: 317, Errors: 0, Failures: 0, Skipped: 18. Time: 18.780363s