Make sccache cache task non-fatal#128052
Merged
Merged
Conversation
github-actions
Bot
added
the
area-Infrastructure-coreclr
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CoreCLR pipeline sccache templates to reduce CI brittleness by making the Azure Pipelines Cache@2 step for the sccache directory non-fatal, so cache upload/restore problems don’t fail the overall build.
Changes:
- Mark the
Cache@2“Sccache cache” task ascontinueOnError: trueso failures become warnings. - Expand sccache setup/stats execution to include Linux
_musllegs and incorporateosSubgroupinto the cache key/restore keys. - Set
SCCACHE_CACHE_SIZEin the sccache configuration step.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| eng/pipelines/coreclr/templates/setup-sccache.yml | Makes sccache cache task non-fatal; adjusts cache keying and eligibility for _musl; sets sccache cache size env var. |
| eng/pipelines/coreclr/templates/sccache-stats.yml | Aligns sccache stats collection eligibility with the updated _musl gating. |
agocke
force-pushed
the
sccache-continue-on-error
branch
from
37cb997 to
e6e4e9c
Compare
The Cache@2 task for sccache can fail when the disk runs out of space during the post-job cache upload. This is purely a performance optimization, so a failure should not fail the entire build. Add continueOnError: true so the task reports a warning instead of an error on failure. Fixes dotnet#128051 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
agocke
force-pushed
the
sccache-continue-on-error
branch
from
e6e4e9c to
29e4f7c
Compare
steveisok
approved these changes
May 11, 2026
Open
3 tasks
Member
Author
|
/ba-g timeouts in unrelated legs |
agocke
added a commit
to agocke/runtime
that referenced
this pull request
May 12, 2026
The 3.5 GiB limit was causing sccache to evict useful entries, dropping the hit rate from ~97% to ~89%. The full working set is around 7-8 GiB. Bumping to 5 GiB should recover most of the hit rate. With continueOnError on the Cache task (dotnet#128052), any disk space issues during upload will no longer fail the build. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
agocke
added a commit
to agocke/runtime
that referenced
this pull request
May 12, 2026
The 3.5 GiB limit was causing sccache to evict useful entries, dropping the hit rate from ~97% to ~89%. The full working set is around 7-8 GiB. Bumping to 5 GiB should recover most of the hit rate. With continueOnError on the Cache task (dotnet#128052), any disk space issues during upload will no longer fail the build. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR was created with Copilot assistance.
The
Cache@2task for sccache can fail when the disk runs out of space during the post-job cache upload (see build log). Since this is purely a performance optimization, a failure should not fail the entire build.This adds
continueOnError: trueso the task reports a warning instead of an error on failure.Fixes #128051