-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Fix #74020: Optimize consecutive shifts in JIT Lowering #122533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This change implements a peephole optimization in Lowering::LowerShift to combine consecutive right shifts (RSH/RSZ) with constant amounts. It specifically addresses cases where division optimization introduces redundant shifts, such as (x / c1) / c2.
bd15d1d to
4aa8c26
Compare
0b10860 to
cca8115
Compare
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
tannergooding
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I do still think this would be better to handle in morph and that it would be good to track RSH(x, n) for 0 < n < bitWidth as being "never negative", but will defer to other input.
CC. @dotnet/jit-contrib for secondary review
Description
This PR addresses issue #74020 by implementing a peephole optimization in JIT Lowering to combine consecutive right shift operations (GT_RSH/GT_RSZ) with constant shift amounts.
Fix
The optimization logic is added to
Lowering::LowerShiftand handles:(x >> c1) >> c2->x >> (c1 + c2)(cast (x >> c1)) >> c2->cast (x >> (c1 + c2))Verification