Enable TelemetryTest
#121498
Open
Enable TelemetryTest
#121498
+0
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes platform-specific test exclusions and an unused helper property. The changes resolve previously tracked issues for Browser and MonoAOT platforms that were preventing the EventSource_ExistsWithCorrectId test from running.
- Removes two
[ActiveIssue]attributes from theEventSource_ExistsWithCorrectIdtest that were blocking execution on Browser and MonoAOT platforms - Removes the unused
IsBrowserAndIsBuiltWithAggressiveTrimmingproperty fromPlatformDetection
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/libraries/System.Net.Http/tests/FunctionalTests/TelemetryTest.cs | Removes ActiveIssue attributes that were preventing test execution on Browser and MonoAOT platforms |
| src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs | Removes unused helper property that was only referenced in the removed ActiveIssue attribute |
This was referenced Nov 10, 2025
Open
Member
Author
|
Passed, see testResults.xml |
ilonatommy
added
arch-wasm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running in EAT mode, locally with Chrome does not reveal any problems. The failures were deterministic when disabled. Disabling happened just after emscripten bump to
3.1.12. Now we are on3.1.56.Reverts:
System.Net.Http.Functional.Tests.TelemetryTestwithEnableAggressiveTrimming && Scenario=WasmTestOnChrome#109179 (addedIsBrowserAndIsBuiltWithAggressiveTrimming)Fixes #71877, fixes #109024.