Fixes for generics and shared generics #121494
Merged
+44
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A couple fixes for things I ran into as I work on generic virtual method support with runtime async.
src/coreclr/tools/Common/TypeSystem/IL/Stubs/AsyncResumptionStub.cs
Outdated
Show resolved
Hide resolved
MichalStrehovsky
added
area-NativeAOT-coreclr
runtime-async
and removed
area-crossgen2-coreclr
labels
Contributor
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for handling generic instantiations of async methods in the AOT compilation pipeline. The changes enable async resumption stubs and async method variants to correctly handle type and method generic parameters.
Key changes:
- Updated token kind checking to support the
CORINFO_TOKENKIND_Awaitflag which is a composite flag - Added
Instantiationproperty toAsyncResumptionStubto support generic methods - Implemented proper instantiation handling for async resumption stubs with generic type and method parameters
- Created
AsyncEcmaMethodILwrapper to correctly associate IL with async method variants
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| CorInfoImpl.RyuJit.cs | Changed Debug.Assert to use bitwise AND check for composite CORINFO_TOKENKIND_Await flag |
| AsyncResumptionStub.cs | Added Instantiation property override to expose owning method's generic parameters |
| NativeAotILProvider.cs | Added AsyncEcmaMethodIL wrapper class to correctly associate IL with async variant method |
| CorInfoImpl.cs | Added token type check for async await, and implemented proper instantiation handling for async resumption stubs |
This was referenced Nov 10, 2025
jkotas
reviewed
Nov 11, 2025
src/coreclr/tools/Common/TypeSystem/IL/Stubs/AsyncResumptionStub.cs
Outdated
Show resolved
Hide resolved
jkotas
approved these changes
Nov 11, 2025
Member
Author
|
/ba-g android timeouts are known |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple fixes for things I ran into as I work on generic virtual method support with runtime async.
Cc @dotnet/ilc-contrib