Add support for emitting Mach-O R2R images #121186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PE writer, don't do that for other formats where we don't have the PE Optional Header.
… little different).
…y only one valid way to write the symbol range
jkoritzinsky
force-pushed
the
macho-r2r
branch
from
179146b to
9a08c72
Compare
Member
Author
|
/azp run runtime-ioslike |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run runtime-ioslike |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Member
Author
|
/azp run runtime-ioslike |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run runtime-ioslike |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run runtime-ioslike |
|
Azure Pipelines successfully started running 1 pipeline(s). |
3 tasks
elinor-fung
reviewed
Nov 8, 2025
Member
|
I pulled this down to check out the generated System.Private.CoreLib.dylib built on a mac - targeted osx and ios. |
elinor-fung
approved these changes
Nov 8, 2025
Member
elinor-fung
left a comment
elinor-fung
left a comment
There was a problem hiding this comment.
Aside from the comment about the linker warnings, looks good to me.
am11
reviewed
Nov 8, 2025
…n flow this back to the sdk repo)
…nsion in the macho scenario
elinor-fung
approved these changes
Nov 10, 2025
Member
There was a problem hiding this comment.
Tested locally for macos (osx, not mobile) with the runtime/host changes. With the fix for the flipped *_RELOC_SUBTRACTOR/*_RELOC_UNSIGNED index, I can successfully run a runtime test using the Mach-O R2R SPCL and a Mach-O R2R image for the test assembly itself.
src/coreclr/tools/Common/Compiler/ObjectWriter/MachObjectWriter.cs
Outdated
Show resolved
Hide resolved
src/coreclr/tools/Common/Compiler/ObjectWriter/MachObjectWriter.cs
Outdated
Show resolved
Hide resolved
src/coreclr/tools/Common/Compiler/ObjectWriter/MachObjectWriter.cs
Outdated
Show resolved
Hide resolved
src/coreclr/tools/Common/Compiler/ObjectWriter/MachObjectWriter.cs
Outdated
Show resolved
Hide resolved
src/coreclr/tools/Common/Compiler/ObjectWriter/MachObjectWriter.cs
Outdated
Show resolved
Hide resolved
src/coreclr/tools/Common/Compiler/ObjectWriter/MachObjectWriter.cs
Outdated
Show resolved
Hide resolved
src/coreclr/tools/Common/Compiler/ObjectWriter/MachObjectWriter.cs
Outdated
Show resolved
Hide resolved
src/coreclr/tools/Common/Compiler/ObjectWriter/MachObjectWriter.cs
Outdated
Show resolved
Hide resolved
elinor-fung
added a commit
that referenced
this pull request
Nov 11, 2025
…composite R2R images (#121363) Add the basic runtime flow for calling into the host to get information about a platform-native R2R - see docs/design/coreclr/botr/readytorun-platform-native-envelope.md#runtime-consuming-a-platform-native-r2r-image. - Add `get_native_code_data` callback to `host_runtime_contract` - If a component R2R assembly has `READYTORUN_FLAG_PLATFORM_NATIVE_IMAGE`, invoke the callback to get the R2R header, image size, and image base address - Currently only implemented and tested on Windows (with local changes to include the flag) - Mach-O support will need #121186 Contributes to #120065.
Member
|
/azp run runtime-ioslike |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Nov 13, 2025
elinor-fung
added a commit
to dotnet/sdk
that referenced
this pull request
Dec 1, 2025
Upstream changes from dotnet/runtime#121186
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support in crossgen2 for emitting Mach-O objects.
Does not yet do the runtime support as that depends on #120777