Set DOTNET_CI environment variable for xharness command #120695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the XHarness command configuration to use the DOTNET_CI environment variable instead of HELIX_WORKITEM_ROOT for detecting CI environments. This change aligns with the SkipOnCI attribute's preferred method for CI detection and ensures better reliability since HELIX_WORKITEM_ROOT is only valid on the host machine.
Key Changes
- Replaces HELIX_WORKITEM_ROOT environment variable with DOTNET_CI=true in the XHarness command
- Simplifies CI detection by using the more appropriate DOTNET_CI variable
kotlarmilos
requested review from
akoeplinger,
jkoritzinsky,
premun and
vitek-karas
|
/azp run runtime-ioslike |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
steveisok
approved these changes
Oct 14, 2025
premun
approved these changes
Oct 14, 2025
vitek-karas
reviewed
Oct 14, 2025
vitek-karas
approved these changes
Oct 14, 2025
This was referenced Oct 14, 2025
Open
jkoritzinsky
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the XHarness command to use the DOTNET_CI environment variable for the SkipOnCI attribute instead of HELIX_WORKITEM_ROOT. The HELIX_WORKITEM_ROOT path is only valid on the host machine. The attribute currently checks both variables to detect if the test is running in CI, but we consider DOTNET_CI to be the more appropriate and reliable.