Revert conditionally setting SYSTEM PATH in host install (#118092) #120472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeloff
approved these changes
Oct 9, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts a previous change that conditionally set the system PATH for the .NET host installer. The revert addresses an issue where uninstalling a newer .NET version would incorrectly remove the PATH entry even when older .NET versions remained installed.
- Reverts conditional PATH setting logic that used registry-based checks
- Restores unconditional PATH setting behavior to prevent PATH removal during partial uninstalls
- Changes installer upgrade scheduling to maintain PATH integrity across version changes
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/installer/pkg/sfx/installers/host.wxs | Removes conditional PATH setting logic and restores Environment elements directly in components |
| src/installer/pkg/sfx/installers/dotnet-host.proj | Changes upgrade schedule and removes conditional PATH property references |
Member
Author
|
/backport to release/10.0 |
Contributor
|
Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/18383401933 |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#118092 causes the path to
dotnet.exeto be removed from PATH even when there are previous installs. For a repro, (1) install .NET 9.0, (2) install .NET 10 RC1, (3) uninstall .NET 10 RC1. The path todotnet.exewill be removed from PATH even though .NET 9.0 is still installed.