Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 26, 2025

Backport of #120119 to release/10.0

/cc @max-charlamb

Customer Impact

  • Customer reported
  • Found internally

After working on #119965, we found that serveral debugger tests were failing as they couldn't find a MethodDesc in the MethodDef -> MethodDesc lookup map on a Module. While this isn't strictly required in ICorDebug, it allows us to have better error messaging and assertions. The current logic prevents the debugger from finding some stack allocated variables and presenting them to the user in minidumps.

This change explicitly ensures that the data required to map a MethodDef -> MethodDesc is available in minidumps for MethodDescs on the stack.

Regression

  • Yes
  • No

When adding the GetReJITInformation cDAC API, we inadvertently removed the call to LookupMethodDef from ILCodeVersion::GetIL.

Testing

We added an automated test in the diagnostics repo.

Risk

Low

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

Package authoring no longer needed in .NET 9

IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.

@steveisok steveisok added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Sep 26, 2025
@steveisok
Copy link
Member

Before moving this forward, we need to add mini dump tests in the diagnostics repo. That is tracked in dotnet/diagnostics#5577

@max-charlamb
Copy link
Member

MiniDumpLocalVarLookup test added for bug repro

dotnet/diagnostics#5579, test fails with current runtime version diagnostic repo targets.
See runtime-diagnostics using current head of runtime/main. The CI runs use an older version of the runtime build without the fixes.

@steveisok steveisok added Servicing-consider Issue for next servicing release review and removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) labels Oct 3, 2025
@steveisok steveisok self-requested a review October 3, 2025 19:11
@JulieLeeMSFT JulieLeeMSFT added this to the 10.0.0 milestone Oct 3, 2025
Copy link
Member

@JulieLeeMSFT JulieLeeMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@steveisok steveisok added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Oct 3, 2025
@steveisok steveisok merged commit c0368f5 into release/10.0 Oct 3, 2025
104 of 113 checks passed
@steveisok steveisok deleted the backport/pr-120119-to-release/10.0 branch October 3, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants