[release/10.0] include memory required to do MethodDefLookup in minidumps #120148
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #120119 to release/10.0
/cc @max-charlamb
Customer Impact
After working on #119965, we found that serveral debugger tests were failing as they couldn't find a MethodDesc in the MethodDef -> MethodDesc lookup map on a Module. While this isn't strictly required in ICorDebug, it allows us to have better error messaging and assertions. The current logic prevents the debugger from finding some stack allocated variables and presenting them to the user in minidumps.
This change explicitly ensures that the data required to map a MethodDef -> MethodDesc is available in minidumps for
MethodDesc
s on the stack.Regression
When adding the GetReJITInformation cDAC API, we inadvertently removed the call to
LookupMethodDef
fromILCodeVersion::GetIL
.Testing
We added an automated test in the diagnostics repo.
Risk
Low
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging
, notrelease/X.0
.Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.