[interp] Suppress tailcall flag if target is a non-marshaled pinvoke #119777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the interpreter's call handling where tailcall flags were incorrectly applied to non-marshaled pinvoke calls. The fix suppresses the tailcall optimization when the target is a non-marshaled pinvoke, which resolves a specific regression test failure.
- Adds conditional logic to disable tailcall for non-marshaled pinvoke targets
- Removes an assertion that was preventing the code from handling this case properly
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
davidwrighton
approved these changes
Sep 16, 2025
…ling a marshaled pinvoke should work since the stub is IL)
kg
force-pushed
the
interp-tailcall-pinvoke
branch
from
75d4407 to
54c8d6d
Compare
3 tasks
69 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JIT\Regression\CLR-x86-JIT\V1-M09.5-PDC\b28901