[release/10.0] [NativeAOT] Fix floating pointer register unwinding on Arm32 #119150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
NativeAOT specific register window implementation has to match the one in libunwind.
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
janvorli
approved these changes
Aug 27, 2025
jeffschwMSFT
approved these changes
Aug 27, 2025
3 tasks
|
/ba-g infrastructure timeout on osx-x64 that's not affected by this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #118944 to release/10.0
/cc @jkotas
Customer Impact
[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]
Regression
This is latent bug (existed in .NET 9 too) in floating pointer register unwinding on Arm32 that was made more severe by recent fix. The bug manifests as corrupted values in floating point local variables after an exception is caught and handled.
Many NativeAOT tests fail on linux-arm32 due to this bug. The failure was misdiagnosed as infrastructure issue that made it linger around longer.
Testing
NativeAOT outer loop, targeted test
Risk
Low
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.