[release/9.0-staging] Fix recursion issue found in PROCCreateCrashDump#119128
Merged
hoyosjs merged 1 commit intorelease/9.0-stagingfrom Sep 15, 2025
Merged
Conversation
steveisok
changed the title
jeffschwMSFT
approved these changes
Sep 3, 2025
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
lgtm. please get a code review. we will take for consideration in 9.0.x
Contributor
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
mangod9
approved these changes
Sep 3, 2025
tommcdon
approved these changes
Sep 4, 2025
rbhanda
added
Servicing-approved
This was referenced Oct 14, 2025
Merged
Closed
Merged
This was referenced Oct 16, 2025
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #110379 to release/9.0-staging
/cc @steveisok @mikem8361
Customer Impact
As reported in #118049, when running an application on Linux as PID=1 (the primary process), the process can hang when there's an unhandled exception with crash dumps enabled. The primary process ends up sending a different signal (
SIGSEGV) duringabort()where we fail to terminate the process and end up spinning indefinitely.The fix is to break out of
PROCCreateCrashDumpif we detect the process re-enters the function.This was originally fixed in #110379, but did not get backported to 9.
Regression
Testing
Manual - triggering an unhandled exception as the primary process.
Risk
Low
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.