[release/9.0-staging] [mono][debugger] Fix assertion when stepping#118459
Merged
steveisok merged 3 commits intorelease/9.0-stagingfrom Sep 4, 2025
Merged
[release/9.0-staging] [mono][debugger] Fix assertion when stepping#118459steveisok merged 3 commits intorelease/9.0-stagingfrom
steveisok merged 3 commits intorelease/9.0-stagingfrom
Conversation
github-actions
bot
requested review from
lambdageek and
steveisok
as code owners
This was referenced Aug 6, 2025
jeffschwMSFT
approved these changes
Aug 7, 2025
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
lgtm. please get a code review. we will take for consideration in 9.0.x
Member
|
This triggered issues during macios bump. It will need follow up fix #118542 |
BrzVlad
approved these changes
Aug 8, 2025
leecow
added
Servicing-approved
Member
|
/ba-g Too generic of a timeout |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #118458 to release/9.0-staging
Backport of #118459
/cc @thaystg
Customer Impact
This is a long standing debugger issue impacting MAUI customers that target iOS arm64. They experience a runtime crash after trying to step over from a previously hit breakpoint. We were incorrectly assuming the native offset from the breakpoint trampoline was always divisible by 4.
Customers could work around this by breaking somewhere else.
dotnet/macios#18586
#110016
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
Manually tested with the user sample.
Risk
Low risk, we copied the way that was done on amd64 to arm64.