Disable LargeUriAndHeaders_Works test on browser #117946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR disables the LargeUriAndHeaders_Works test on browser platforms by changing it from a [Fact] to a [ConditionalFact] that only runs when not on browser. The test was originally designed to validate large URI handling through the SocketsHttpHandler stack end-to-end, which is not relevant for browser environments.
Key changes:
- Changed test attribute from
[Fact]to[ConditionalFact]with browser exclusion - Removed browser-specific length logic since the test no longer runs on browser
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs
Outdated
Show resolved
Hide resolved
|
Tagging subscribers to this area: @dotnet/ncl |
Open
3 tasks
ManickaP
approved these changes
Jul 23, 2025
|
/ba-g Build analysis isn't picking up WASM queue timeouts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #117942
I added the test just to see if large Uris flow through the SocketsHttpHandler stack E2E, not that interesting for browser.