Skip to content

Fix WebSocket test causing assert #117507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2025
Merged

Fix WebSocket test causing assert #117507

merged 1 commit into from
Jul 11, 2025

Conversation

CarnaViire
Copy link
Member

Fixes ConnectAsync_Http11WithRequestVersionOrHigher_Loopback_Success that used UseSsl=true without checking for PlatformDetection.SupportsAlpn

Fixes #117293

@Copilot Copilot AI review requested due to automatic review settings July 10, 2025 15:23
Copilot
Copilot AI reviewed Jul 10, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR ensures the ConnectAsync_Http11WithRequestVersionOrHigher_Loopback_Success test only runs on platforms with ALPN support, preventing an assertion failure on platforms without ALPN.

  • Replaces [Fact] with [ConditionalFact] checking PlatformDetection.SupportsAlpn for the affected test.

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 10, 2025
@CarnaViire CarnaViire added area-System.Net and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 10, 2025
@CarnaViire
Copy link
Member Author

/azp run runtime-extra-platforms

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jul 10, 2025
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
Open
Open
Closed
Closed
@CarnaViire
Copy link
Member Author

The test is now properly skipped for platforms not supporting ALPN, e.g.:

@CarnaViire CarnaViire mentioned this pull request Jul 11, 2025
Open
@CarnaViire
Copy link
Member Author

/ba-g test failures are unrelated crashes from runtime-extra-platforms

@CarnaViire CarnaViire merged commit 1df4e52 into dotnet:main Jul 11, 2025
121 of 146 checks passed
@CarnaViire CarnaViire deleted the ws-ios-pnse branch July 11, 2025 00:45
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot Copilot left review comments

@antonfirsov antonfirsov antonfirsov approved these changes

Assignees

@CarnaViire CarnaViire

Labels
area-System.Net
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[iOS] System.PlatformNotSupportedException: The PKCS#12 Exportable flag is not supported on this platform.
2 participants
@CarnaViire @antonfirsov