[HTTP] H/3 fix test closing server connection prematurely #117458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManickaP
added
NO-MERGE
|
Tagging subscribers to this area: @dotnet/ncl |
There was a problem hiding this comment.
Pull Request Overview
This PR instruments existing HTTP handler tests with console output to help diagnose CI test failures.
- Adds
Console.WriteLinein the test base to log ignored exceptions. - Adds
Console.WriteLinein a specific test to log the caught client exception.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTestBase.cs | Added console logging for ignored exceptions in the base test helper |
| src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs | Added console logging for the exception thrown by client.SendAsync |
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTestBase.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs
Outdated
Show resolved
Hide resolved
This was referenced Jul 9, 2025
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jul 10, 2025
Open
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ManickaP
force-pushed
the
test-header-fail
branch
from
f901ed1 to
08d0bcd
Compare
ManickaP
changed the title
ManickaP
removed
NO-MERGE
CarnaViire
reviewed
Jul 17, 2025
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs
Outdated
Show resolved
Hide resolved
ManickaP
force-pushed
the
test-header-fail
branch
from
ccaf881 to
6a8f216
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds more synchronization into the test so that the server doesn't close before the client can observe the expected exception.
Fixes #117198