Set a default for the Http3Support feature switch #117081
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Control over this is moving from dotnet/runtime repo build time to publish time so we need to set a default that matches the old build-time setting. Ref #117012 Ref dotnet/sdk#49564
There was a problem hiding this comment.
Pull Request Overview
This PR sets a default value for the Http3Support feature switch to false in the WasmFeatures.props file, aligning the publish time behavior with the previous build-time setting.
- Default for Http3Support added.
- Consistency with previous dotnet/runtime behavior ensured.
github-actions
bot
added
the
needs-area-label
|
This file moved to https://github.com/dotnet/sdk/blob/main/src/Workloads/Manifests/Microsoft.NET.Workload.Mono.Toolchain.Current.Manifest/WasmFeatures.props. Looks like I missed removing it here, I'll get that done. |
Ah, thanks. New PR at dotnet/sdk#49583. |
This was referenced Jun 27, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Control over this is moving from dotnet/runtime repo build time to publish time so we need to set a default that matches the old build-time setting.
Ref #117012
Ref dotnet/sdk#49564