Reduce HTTP headers validation overhead #117071
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding/reading headers where we don't have a special parser, "parsing" only validates that there are no new lines in the value. This change special-cases this (common) case and avoids allocating the
HeaderStoreItemInfo
.Existing code paths where only non-validating APIs are used stay the same.
Overhead for cases of reading headers with validation, where they were added without validation, and we do have a known parser (still common) is minimal and an acceptable tradeoff IMO (extra branch).
Benchmark code