Skip to content

[release/9.0-staging] Skip SSL key log test for OpenSSL 3.5+ #116687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 23, 2025
Merged

[release/9.0-staging] Skip SSL key log test for OpenSSL 3.5+ #116687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c66156b
Skip SSL key log test for openssl 3.5+
rokonec Jun 10, 2025
5558b4e
Minor changes, active issue comment
rokonec Jun 12, 2025
41a1737
Conditional return
rokonec Jun 12, 2025
27a16e4
Add IsOpenSsl3_5 to platform detection helper
rokonec Jun 16, 2025
f175437
Merge branch 'release/9.0-staging' into backport/pr-116474-to-release…
rokonec Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Unix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,11 @@ public static partial class PlatformDetection

private static readonly Version s_openssl3Version = new Version(3, 0, 0);
private static readonly Version s_openssl3_4Version = new Version(3, 4, 0);
private static readonly Version s_openssl3_5Version = new Version(3, 5, 0);

public static bool IsOpenSsl3 => IsOpenSslVersionAtLeast(s_openssl3Version);
public static bool IsOpenSsl3_4 => IsOpenSslVersionAtLeast(s_openssl3_4Version);
public static bool IsOpenSsl3_5 => IsOpenSslVersionAtLeast(s_openssl3_5Version);

/// <summary>
/// If gnulibc is available, returns the release, such as "stable".
Expand Down
8 changes: 8 additions & 0 deletions src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamRemoteExecutorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ public SslStreamRemoteExecutorTests()
[PlatformSpecific(TestPlatforms.Linux)] // SSLKEYLOGFILE is only supported on Linux for SslStream
[InlineData(true)]
[InlineData(false)]
//[ActiveIssue("https://github.com/dotnet/runtime/issues/116473")]
public async Task SslKeyLogFile_IsCreatedAndFilled(bool enabledBySwitch)
{
if (PlatformDetection.IsDebugLibrary(typeof(SslStream).Assembly) && !enabledBySwitch)
Expand All @@ -34,6 +35,13 @@ public async Task SslKeyLogFile_IsCreatedAndFilled(bool enabledBySwitch)
return;
}

if (PlatformDetection.IsOpenSsl3_5 && !enabledBySwitch)
{
// OpenSSL 3.5 and later versions log into file in SSLKEYLOGFILE environment variable by default,
// regardless of AppContext switch.
return;
}

var psi = new ProcessStartInfo();
var tempFile = Path.GetTempFileName();
psi.Environment.Add("SSLKEYLOGFILE", tempFile);
Expand Down