Skip to content

Conversation

jozkee
Copy link
Member

@jozkee jozkee commented Jun 10, 2025

MERGE COMMIT

OOB reset needed for:
#115008
#112861

github-actions bot and others added 15 commits May 21, 2025 13:53
…e now supporting multiple declarations. (dotnet#115077)

* Account for CompilationMappingAttribute supporting multiple declarations.

* Update package version

---------

Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>
Co-authored-by: Maoni0 <maoni@microsoft.com>
…ationToken Callback (dotnet#115841)

* Ignore ObjectDisposedException on CancellationToken Callback

* Update src/libraries/System.Net.NameResolution/src/System/Net/NameResolutionPal.Windows.cs

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

* Change wording in comment

* Update src/libraries/System.Net.NameResolution/src/System/Net/NameResolutionPal.Windows.cs

---------

Co-authored-by: Ahmet Ibrahim Aksoy <aaksoy@microsoft.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
…ismatch (dotnet#116208)

* JIT: Fix SysV first/second return register GC info mismatch when generating calls

* Fix struct ReturnKind on SysV AMD64.

On SysV AMD64, structs returned in a float and int reg pair were being
classified as RT_Scalar_XX. This causes downstream consumers
(e.g., HijackFrame::GcScanRoots) to look for obj/byref's in
the second int reg. Per the ABI, however, the first float is passed
through a float reg and the obj/byref is passed through the _first_
int reg. We now detect and fix this case by skipping the first float
type in the ReturnKind encoding and moving the second type into the
first.

Fix dotnet#115815

---------

Co-authored-by: zengandrew <7494393+zengandrew@users.noreply.github.com>
…tree walk (dotnet#116240)

* Add a parent check to forward sub tree walk

* More checks

---------

Co-authored-by: SingleAccretion <AccretionMail@yandex.ru>
When a foreign thread running in .NET process is killed or crashes due
to some hardware exception, the .NET code that performs shutdown gets
called and incorrectly expects the thread to be a thread that's
registered with the runtime. It calls GetThread on it and then calls a
method on the thread. That leads to an assert in debug builds and crash
in release ones.

The function that is called is not needed for foreign threads though, so
the fix is to skip calling it if the GetThreadNULLOk returns NULL (that
means the thread is foreign and never registered with the runtime).

Co-authored-by: Jan Vorlicek <janvorli@microsoft.com>
…ing mode

Co-authored-by: Raphael Catolino <raphael.catolino@ovhcloud.com>
…posed with a pending operation (dotnet#116189)

* Fix PipeStream cleanup on Windows when pipe is disposed with a pending operation

The same pattern occurs in a couple of other places, as well.

* Make dispose cancellation unconditional

---------

Co-authored-by: Stephen Toub <stoub@microsoft.com>
Co-authored-by: Thays Grazia <thtaglia@microsoft.com>
Co-authored-by: Tom McDonald <tommcdon@microsoft.com>
…ld 20250516.1 (dotnet#115676)

Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
 From Version 8.0.0-beta.25211.2 -> To Version 8.0.0-beta.25266.1

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…ild 20250515.1 (dotnet#115623)

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 8.0.0-alpha.0.25214.2 -> To Version 8.0.0-alpha.0.25265.1

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…ence-packages build 20250410.2 (dotnet#115586)

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 8.0.0-alpha.1.25081.5 -> To Version 8.0.0-alpha.1.25210.2

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…5050.2 (dotnet#115585)

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 8.0.0-prerelease.25207.2 -> To Version 8.0.0-prerelease.25255.2

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: David Cantú <dacantu@microsoft.com>
…e handle (dotnet#115379)

* Link peer's X509 stack handle to parent SSL safe handle

* Update src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Ssl.cs

Co-authored-by: Kevin Jones <vcsjones@github.com>

* Add test for dispose parallel with handshake.

* Revert "Add test for dispose parallel with handshake."

This reverts commit 3cae60b.

* Defer RemoteCertificate assignment after X509 Chain build (dotnet#114781)

* Defer RemoteCertificate assignment after X509 Chain build

* Add comment

* Fix SslStreamDisposeTest failures during parallel handshake (dotnet#113834)

* Fix SslStreamDisposeTest.Dispose_ParallelWithHandshake_ThrowsODE test failures

* Fix build

* Fix SslStreamDisposeTest for parallel handshake on Unix (dotnet#114100)

* [Test Failure] SslStreamDisposeTest.Dispose_ParallelWithHandshake_ThrowsODE on Unix
Fixes dotnet#113833

* fixup! [Test Failure] SslStreamDisposeTest.Dispose_ParallelWithHandshake_ThrowsODE on Unix Fixes dotnet#113833

* fixup! fixup! [Test Failure] SslStreamDisposeTest.Dispose_ParallelWithHandshake_ThrowsODE on Unix Fixes dotnet#113833

* Update src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamDisposeTest.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Fix build

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Radek Zikmund <r.zikmund.rz@gmail.com>
Co-authored-by: Radek Zikmund <32671551+rzikm@users.noreply.github.com>
Co-authored-by: Kevin Jones <vcsjones@github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…115587)

* Update dependencies from https://github.com/dotnet/arcade build 20250513.4

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.25214.7 -> To Version 8.0.0-beta.25263.4

* Bump MicrosoftDotnetSdkInternalVersion to 8.0.116

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: David Cantú <dacantu@microsoft.com>
@jozkee jozkee requested review from a team and Copilot June 10, 2025 03:49
@jozkee jozkee added NO-SQUASH The PR should not be squashed Servicing-approved Approved for servicing release labels Jun 10, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@ericstj
Copy link
Member

ericstj commented Jun 10, 2025

@lewing - build leg hung while building browser wasm tests. > browser-wasm linux Release AllSubsets_Mono_RuntimeTests monointerpreter

https://dev.azure.com/dnceng-public/public/_build/results?buildId=1063269&view=logs&j=3e93a48f-6568-53f2-76b3-1285c183c39d&t=313dc435-bc2e-554b-c5b1-106790cdfaec&l=1001

Could it be that this build is running out of memory?

Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the build failure is a build wasm timeout and all others look known.

@jozkee
Copy link
Member Author

jozkee commented Jun 10, 2025

/ba-g agent/machine restarted, all other are known test issues.

@jozkee jozkee merged commit 56fecbb into dotnet:release/8.0 Jun 10, 2025
192 of 195 checks passed
@jozkee jozkee deleted the release/8.0-staging branch June 10, 2025 19:43
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2025
@jozkee jozkee restored the release/8.0-staging branch July 14, 2025 23:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-SQUASH The PR should not be squashed Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants